Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnome-text-editor application in business-vm #803

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Sep 26, 2024

Description of changes

gnome-text-editor is added into business-vm with icon

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • Lenovo X1 x86_64
  • Is this a new feature
    • List the test steps to verify:
      • Open the ghaf launcher on the left down corner in the guivm.
      • Run the gnome-text-editor app by clicking the icon.
  • If it is an improvement how does it impact existing functionality?

@Nerox9 Nerox9 temporarily deployed to internal-build-workflow September 26, 2024 10:04 — with GitHub Actions Inactive
@clayhill66 clayhill66 added the Needs Testing CI Team to pre-verify label Sep 26, 2024
@milva-unikie

This comment was marked as outdated.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Sep 26, 2024
Copy link
Member

@humaidq-tii humaidq-tii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about an application like gnome-text-editor, which would be friendly to a non-technical user and we wouldn’t be bringing in Qt dependencies.

Also readme of the notepad-next project states:

it should not be considered safe for critically important work

@Nerox9
Copy link
Contributor Author

Nerox9 commented Sep 27, 2024

How about an application like gnome-text-editor, which would be friendly to a non-technical user and we wouldn’t be bringing in Qt dependencies.

Also readme of the notepad-next project states:

it should not be considered safe for critically important work

Notepad-Next is replaced by gnome-text-editor app.

@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify and removed Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon labels Sep 27, 2024
@milva-unikie

This comment was marked as outdated.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Sep 30, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow September 30, 2024 10:17 — with GitHub Actions Inactive
@Nerox9 Nerox9 changed the title Add notepad next application in guivm Add gnome-text-editor application in guivm Sep 30, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow October 1, 2024 12:14 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow October 1, 2024 12:14 — with GitHub Actions Inactive
@Nerox9 Nerox9 changed the title Add gnome-text-editor application in guivm Add gnome-text-editor application in business-vm Oct 1, 2024
@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify and removed Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Needs Testing CI Team to pre-verify labels Oct 1, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow October 1, 2024 13:58 — with GitHub Actions Inactive
@Nerox9 Nerox9 added the Needs Testing CI Team to pre-verify label Oct 1, 2024
@milva-unikie

This comment was marked as outdated.

@milva-unikie milva-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Oct 2, 2024
@humaidq-tii
Copy link
Member

This app does not have the standard colorful border

The ID for the window might be: org.gnome.TextEditor.desktop, that can be set for border colors. It will probably look something like AppFlowy, with the window controls part of the application, not the border.

@Nerox9
Copy link
Contributor Author

Nerox9 commented Oct 2, 2024

Tested on Lenovo-X1 (nixos-rebuild switch)

* Gnome Text Editor opens in business-vm.

* Text files can be created, opened, edited and saved inside business-vm.

* Green line around the window indicates that it is running in business-vm.

* This is much more simplified than Notepad Next, but I think it does everything needed.

Issues:

* This app does not have the standard colorful border (with minimize, maximize and close buttons). All the other apps have it in business-vm.  This should probably be fixed before merging.

* As a smaller issue: Some options are not working in menus
  
  * In Main Menu 'Dark Style' and 'Light Style' do nothing.
  * In Options Menu (the one left of main menu) only document type can be changed. All the other options seem to do nothing.
  * -> Probably not the end of the world if some of these don't work, but I would guess they should be working in the app?

It has a similar appearance to AppFlowy as @humaidq-tii mentioned. after the new commit.
Missing icons and not working UI are fixed by dconf.

@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Oct 2, 2024
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

  • Gnome Text Editor opens in business-vm.
  • Text files can be created, opened, edited and saved inside business-vm.
  • Green line around the window indicates that it is running in business-vm.
  • The app has the standard Ghaf border (with minimize, maximize and close buttons).
  • All menu options now work.

Can I make one last small request? The color of the border is quite aggressively green and the contrast in the top bar is not good. As far as I know we don't have guidelines on what the colors should be, but something a bit softer would be great.

Sorry if I was unclear about that in my previous comment. The apps in business-vm have two "borders". The green inside line indicating that the app is in business-vm and then the outside border that almost all apps have.

image

@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Oct 3, 2024
gnome-text-editor is added in business-vm with icon

Signed-off-by: Berk Arslan <[email protected]>
Copy link

@milva-unikie milva-unikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color is fixed now!

@milva-unikie milva-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Oct 3, 2024
@brianmcgillion brianmcgillion merged commit f11d937 into tiiuae:main Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants