-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gnome-text-editor application in business-vm #803
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about an application like gnome-text-editor, which would be friendly to a non-technical user and we wouldn’t be bringing in Qt dependencies.
Also readme of the notepad-next project states:
it should not be considered safe for critically important work
Notepad-Next is replaced by gnome-text-editor app. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The ID for the window might be: |
It has a similar appearance to AppFlowy as @humaidq-tii mentioned. after the new commit. |
Tested on Lenovo-X1 (
Can I make one last small request? The color of the border is quite aggressively green and the contrast in the top bar is not good. As far as I know we don't have guidelines on what the colors should be, but something a bit softer would be great. Sorry if I was unclear about that in my previous comment. The apps in business-vm have two "borders". The green inside line indicating that the app is in business-vm and then the outside border that almost all apps have. |
gnome-text-editor is added in business-vm with icon Signed-off-by: Berk Arslan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color is fixed now!
Description of changes
gnome-text-editor is added into business-vm with icon
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
x86_64